-
Notifications
You must be signed in to change notification settings - Fork 299
[CLI] Restore the "login" argument handler #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@adamziel I realized my mistake with removing What caused the confusion for me is that I expected the wordpress-playground/packages/playground/cli/src/cli.ts Lines 209 to 220 in 236c236
Should we allow the |
@@ -104,7 +104,7 @@ async function run() { | |||
}) | |||
.option('debug', { | |||
describe: | |||
'Return PHP error log content if an error occurs while building the site.', | |||
'Print PHP error log content if an error occurs during Playground boot.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related discussion #1983 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! a --debug
flag that doesn't cover the entire lifecycle of the app seems confusing to me. What do you think about either renameing it to --debug-boot
or making it work after the boot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add request debugging. Here is an issue to track it #1988
Potentially – this is a nice moment to explore reusing the same code paths for resolving the Blueprint in the web app and in the CLI. Would doing that be useful? If yes, what would be the most effective way to do it? |
Thanks! I will leave it as is for now, but if it comes up in the future we can take a look at it. |
We already have an open issue to allow the wp, php arguments to override Blueprints. |
This PR restores support for login in the CLI using a
login
argument.The support was previously removed in #1811.
Testing Instructions (or ideally a Blueprint)
bun ./packages/playground/cli/src/cli.ts server --login