Skip to content

Add mbstring support to the web php wasm #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

akirk
Copy link
Member

@akirk akirk commented Apr 20, 2023

This is just a first attempt to see if its feasible. It adds about 800kb to the wasm.

@adamziel
Copy link
Collaborator

adamziel commented Apr 21, 2023

The PR is great, thank you @akirk!

At the same time, 800kb is quite a bit. Here are the numbers after compression:

 php_8_1.wasm: 6.5M vs 5.7M
 php_8_1.wasm.gz: 2.6M vs 2.0M
 php_8_1.wasm.br:  1.9M vs 1.5M

At this point I think a web-full build would make more sense and it could also include libxml that adds another 1M. Technically, it would require another preset in build.js and another recompile script in packages/php-wasm/web/project.json. Once that's in place, the getPHPLoaderModule() function could be updated to support versions like 8.2-full (or to accept tag=full).

@adamziel adamziel mentioned this pull request Apr 27, 2023
56 tasks
@adamziel
Copy link
Collaborator

This got a bit stale so let's close it for now.

@adamziel adamziel closed this May 30, 2023
adamziel added a commit that referenced this pull request Dec 11, 2023
…review links (#212)

The preview links attached to Pull Requests exported to GitHub are now
using the new `import-site` Query API param merged in #610. Before this
commit, these preview URLs used Blueprints, which were more verbose and
difficult to modify by hand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants