PHP Node: Only consider NODEFS to be a shared filesystem #2300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
#2231 overrides
FS.hashAddNode
withfunction hashAddNodeIfNotSharedFS(node)
where additional logic applies ifis_shared_fs_node(node)
is true. Only NODEFS nodes were supposed to be considered as coming from a shared fs. Unfortunately, the internal logic ofis_shared_fs_node()
also returned true for MEMFS nodes. This caused a FS error 44 for the following operation whereruntime2
attempts to create a directory in a/wordpress
directory mounted fromruntime1
:Specifically, the FS error 44 was triggered inside
is_shared_fs_node()
when calling NODEFS operations on these non-NODEFS nodes.Implementation details
Adds a check confirming the shared node comes from NODEFS.
Testing Instructions (or ideally a Blueprint)
test-unit-jspi
in CI workflow #2285 lands, we'll be able to add a unit testcc @brandonpayton