[CLI] Define CLI --flags for each command individually #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
force-pushed
the
move-flags-docs-to-relevant-commands
branch
from
c31bee7 to
ecde246
Compare
adamziel
changed the title
adamziel
added
[Type] Enhancement
adamziel
force-pushed
the
move-flags-docs-to-relevant-commands
branch
from
0699caf to
3f1c0a3
Compare
The file-locking test suite was using the default port 9400, which could conflict with other tests running in parallel. Added explicit port 9600 to avoid EADDRINUSE errors on Windows CI.
All tests in run-cli.spec.ts now use port 9500 via suiteCliArgs to avoid port conflicts when tests run in parallel or cleanup is slow on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Running
wp-playground --helppreviously displayed all CLI flags in one long list, making it difficult to tell which flags are relevant to which command. This PR scopes flags to their relevant commands so that runningwp-playground server --helpshows only the flags relevant to theservercommand.Implementation details
Refactors the CLI option declarations from a long chain of
.option()calls to object-based option groups:sharedOptions: Options available to all commands (php, wp, mount, blueprint, etc.)serverOnlyOptions: Options specific to theservercommand (port, multi-worker, devtools)buildSnapshotOnlyOptions: Options specific to thebuild-snapshotcommand (outfile)A
commandWithOptions()helper function applies the appropriate options to each command, combining shared options with command-specific ones.Testing Instructions
Run
wp-playground --helpto see the cleaner top-level help, then runwp-playground server --helporwp-playground build-snapshot --helpto verify command-specific options are displayed correctly.