[website] Refactor out an Overlay component from saved-playgrounds-overlay #3152
+580
−650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates reusable Overlay, OverlayHeader, OverlayBody, and OverlaySection components that can be shared across different overlay implementations. This refactor prepares for the persistent deployment overlay.
akirk
force-pushed
the
persistent/overlay-refactor
branch
from
9863d74 to
02c9df6
Compare
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This PR extracts shared overlay components from the
saved-playgrounds-overlayto enable reuse across different overlay implementations. This is preparatory work for the persistent deployment feature, which will introduce a new overlay with similar structure but different content.Implementation details
Creates a new
components/overlay/module with reusable primitives:Overlay- Base container with escape key handling and fade-in animationOverlayHeader- Header with optional logo, title, back button, and close buttonOverlayBody- Scrollable body containerOverlaySection- Section with optional title and descriptionThe
saved-playgrounds-overlayis refactored to use these new components, reducing code duplication and making the overlay structure consistent.Changes:
components/overlay/index.tsxandstyle.module.csssaved-playgrounds-overlay/index.tsx- now uses shared overlay componentssaved-playgrounds-overlay/style.module.css- removed styles that moved to shared overlayThis is a pure refactor with no functional changes.
Testing Instructions (or ideally a Blueprint)