-
Notifications
You must be signed in to change notification settings - Fork 389
Decode HTML entities in JS instead of PHP for site name retrieval #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Adds a dropdown to the backup reminder UI that lets users schedule automatic backup downloads on a daily, every-2-days, or weekly basis. When enabled, the toolbar backup indicator is hidden and backups trigger automatically after WordPress boots.
Remove redundant daysUsedSinceLastBackup tracking. The backup indicator now derives days since last backup directly from backupHistory timestamps, which is simpler and more reliable.
Co-authored-by: adamziel <[email protected]>
Co-authored-by: adamziel <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot retry |
All checks verified and passing: The implementation is complete - PHP now outputs raw |
Per review feedback on #3162, move HTML entity decoding from PHP to JavaScript to follow separation of concerns and security best practices.
Changes:
echo $nameinstead ofecho html_entity_decode($name, ENT_QUOTES, 'UTF-8')decodeHTMLEntities()using DOM-based decoding to safely decode entities while preventing XSSImplementation:
This approach leverages the browser's native entity decoding without introducing parsing vulnerabilities.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.