[Personal-WP] Fix broadcast message loop in tab coordinator #3217
+22
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The tab coordinator was causing an infinite loop of broadcast messages, where
checkForExistingTabswas being called repeatedly. This resulted in continuouspingmessages being sent between BroadcastChannel instances, even within a single tab.The issue had two contributing factors:
tab-coordinator.ts, another inuseTabTrackinghook) could trigger each otheruseCallbackdependency inuseTabTrackingcaused the effect to re-run on every renderImplementation details
tab-coordinator.ts:
isCheckingTabs) to prevent concurrent calls tocheckForExistingTabslastCheckTime+ 1 second minimum interval) to prevent rapid successive callsdestroyTabCoordinatorfor proper cleanupuse-tab-tracking.ts:
useCallbackdependency by storingoptions.onWorkerLostin a refcheckWorkerLostcallback to have empty dependencies[]instead of[options]Testing Instructions (or ideally a Blueprint)
cc @fellyph since you also observed this!