Skip to content

Support PHP 8.3 #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2023
Merged

Support PHP 8.3 #829

merged 2 commits into from
Dec 2, 2023

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Dec 1, 2023 •
edited
Loading

What is this PR doing?

Adds PHP 8.3 to Playground.

Closes #820

CleanShot 2023-12-01 at 11 52 32@2x

Testing Instructions

  1. Go to http://localhost:5400/website-server/ and switch the PHP version to 8.3.
  2. Confirm that WordPress is functional and you can update the site in the site editor
  3. Go to /phpinfo.php, confirm the php version it 8.3
  4. Update settings to run with additional PHP extensions and networking support
  5. Confirm that WordPress is functional, you can update the site in the site editor, and the plugin directory shows plugins and you can install them
  6. Go to /phpinfo.php, confirm the php version it 8.3
  7. In CLI, run PHP=8.3 nx run php-wasm-cli:start -- -i and confirm the PHP version presented on the screen is 8.3

@adamziel adamziel mentioned this pull request Dec 1, 2023
Merged
@seanmorris seanmorris mentioned this pull request Dec 1, 2023
Closed
seanmorris
seanmorris approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@seanmorris seanmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!!!!
👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏

@adamziel adamziel merged commit e4e360d into trunk Dec 2, 2023
@adamziel adamziel deleted the add-php-8-3 branch December 2, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmorris seanmorris seanmorris approved these changes

Assignees
No one assigned
Labels
[Feature] PHP.wasm [Package][@php-wasm] CLI [Type] Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support PHP 8.3
2 participants
@adamziel @seanmorris