Try adding captions to the loading indicator. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it @StevenDufresne! I tweaked it a bit to include the installed theme/plugin name as follows:
Other than that, it's good to go 🚢 |
bgrgicak
pushed a commit
that referenced
this pull request
May 7, 2025
…sions (#83) ## Motivation for the change, related issues Our changelog workflow is currently broken because it is missing extra GitHub token secrets. If we add these secrets, we will have to update them occasionally. I think we may be able to do without and would like to try that. In addition, we need to backfill changelog entries while omitting links to PRs (since we cannot link to our private PRs). ## Implementation details This PR: - Updates our changelog update workflow to persist credentials in the local git config and attempts to follow the example of pushing a commit after actions/checkout: https://github.com/actions/checkout?tab=readme-ov-file#push-a-commit-using-the-built-in-token - Omits PR links from new changelog entries unless they point to github.com/WordPress/wordpress-playground - Backfills changelog entries for v1.0.25 to v1.0.29. ## Testing Instructions (or ideally a Blueprint) - Temporarily disable protections on running the workflow - Make the workflow target the PR branch - Manually run the workflow and see if it commits a changelog update to the PR branch - If successful, remove the changelog commit from the PR branch - Re-enable protections - Re-enable checking out trunk only - Merge
brandonpayton
added a commit
that referenced
this pull request
Jun 4, 2025
…sions (#83) ## Motivation for the change, related issues Our changelog workflow is currently broken because it is missing extra GitHub token secrets. If we add these secrets, we will have to update them occasionally. I think we may be able to do without and would like to try that. In addition, we need to backfill changelog entries while omitting links to PRs (since we cannot link to our private PRs). ## Implementation details This PR: - Updates our changelog update workflow to persist credentials in the local git config and attempts to follow the example of pushing a commit after actions/checkout: https://github.com/actions/checkout?tab=readme-ov-file#push-a-commit-using-the-built-in-token - Omits PR links from new changelog entries unless they point to github.com/WordPress/wordpress-playground - Backfills changelog entries for v1.0.25 to v1.0.29. ## Testing Instructions (or ideally a Blueprint) - Temporarily disable protections on running the workflow - Make the workflow target the PR branch - Manually run the workflow and see if it commits a changelog update to the PR branch - If successful, remove the changelog commit from the PR branch - Re-enable protections - Re-enable checking out trunk only - Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds captions to the progress indicator. This may be a naive approach, but it passes the caption through the
ProgressObserver.Demo
https://d.pr/i/AkiSwg