Skip to content

CPLAT-10037: Add a tool to make managing background processes easier. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Nov 7, 2019

CPLAT-10037

Issue Status

We have a few consumers that start a background process before running a dev tool like tests and then need to stop that process at the end. This PR adds a BackgroundProcessTool to make that easier:

final testServer = BackgroundProcessTool(
    'node', ['tool/server.js'],
    delayAfterStart: Duration(seconds: 1));
final config = {
  'test': CompoundTool()
    ..addTool(testServer.starter, alwaysRun: true)
    ..addTool(TestTool())
    ..addTool(testServer.stopper, alwaysRun: true),
};

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf evanweible-wf force-pushed the background_process_tool branch from c56da52 to d70f82f Compare March 9, 2020 15:28
@evanweible-wf evanweible-wf changed the title WIP: Add a tool to make managing background processes easier. Add a tool to make managing background processes easier. Mar 9, 2020
@evanweible-wf evanweible-wf marked this pull request as ready for review March 9, 2020 15:29
@rmconsole4-wk rmconsole4-wk changed the title Add a tool to make managing background processes easier. CPLAT-10037 Add a tool to make managing background processes easier. Mar 9, 2020
@bender-wk bender-wk changed the title CPLAT-10037 Add a tool to make managing background processes easier. CPLAT-10037: Add a tool to make managing background processes easier. Mar 9, 2020
Copy link
Member

@todbachman-wf todbachman-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@evanweible-wf
Copy link
Contributor Author

QA +1

  • Tests passing and verified locally with sockjs_client_wrapper

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit f2aa756 into master Mar 16, 2020
@rmconsole6-wk rmconsole6-wk deleted the background_process_tool branch March 16, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants