Skip to content

CPLAT-9182: Add --reporter option to TestTool #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Jan 13, 2020

The --reporter option is a commonly used option when running tests. This PR adds it to TestTool so that it can be used directly with ddev test instead of having to use --test-args to configure it.

# before
$ ddev test --test-args="--reporter expanded"
# now
$ ddev test --reporter expanded

Note: the -r abbreviation was intentionally not added because it conflicts with the abbreviation for the --release flag used when running tests via build_runner. In other words, when running tests via ddev test, the -r abbreviation has no meaning and the full option name (either --release or --reporter) should be used to avoid ambiguity.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole4-wk rmconsole4-wk changed the title Add --reporter option to TestTool CPLAT-9182 Add --reporter option to TestTool Jan 13, 2020
@bender-wk bender-wk changed the title CPLAT-9182 Add --reporter option to TestTool CPLAT-9182: Add --reporter option to TestTool Jan 13, 2020
@todbachman-wf
Copy link
Member

QA +1. Works as expected, both with and without the --reporter option.

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 3d75a51 into master Jan 13, 2020
@rmconsole6-wk rmconsole6-wk deleted the testtool_forward_reporter_option branch January 13, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants