Skip to content

Widen analyzer range to allow latest version (0.41.x) #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Feb 3, 2021

Motivation

To unlock the latest analyzer package version, as well as the latest versions of many packages that depend on it, including build packages, we need to widen the version range for this package.

Solution

Widen version range to allow analyzer 0.41.x, the latest minor version.

No other changes were necessary

Testing instructions

Verify locally that there are no analysis issues in this repo when using analyzer 0.41.x

Unfortunately, Dart 2.7.2 (which is what we use in CI) still can't resolve to this latest analyzer version due to SDK dependency constraints on this build package, so this has to be tested locally, with an SDK of at least Dart 2.9.

Also, with the constraint as-is, for some reason pub upgrade analyzer won't resolve the latest version, but you can force it to resolve to analyzer 0.41.x by temporarily making the analyzer dependency ^0.41.0.

-analyzer: ">0.39.0 <0.42.0"
+analyzer: ^0.41.0

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf
Copy link
Contributor

QA +1

analyzer 0.41.2 was installed on the stable CI run, and analysis passed.

@Workiva/release-management-pp

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants