Add import sorting to format tool #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reviewer note: This is copied from dart_dev_workiva for easy reviewing. - This should only contain import changes
- This will allow us to execute multiple processes as part of a `ddev format` command
- I would rather follow Effective Dart guidelines. directives_ordering no longer separates own package from other package. See https://dart.dev/guides/language/effective-dart/style#ordering - prefer_relative_imports seems like a better alternative for packages that wish to separate own package imports https://dart.dev/guides/language/effective-dart/usage#prefer-relative-import-paths
regenvanwalbeek-wf
force-pushed
the
import_sort
branch
from
a01ec78 to
10df9b5
Compare
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
- Prefer `organize` over `clean` or `sort` (unless specifically referencing sorting)
Co-authored-by: Evan Weible <[email protected]>
- This makes it clear that assigning comments has to happen before sorting - This is slightly less stateful than before, which feels slightly better
|
@evanweible-wf The functional tests I added appear to be failing on stable (pass on 2.13). They're passing for me locally running on stable. Do you see anything immediately obvious? |
evanweible-wf
previously approved these changes
Jul 25, 2022
evanweible-wf
approved these changes
Jul 26, 2022
|
Skynet test results failed initially for this build but were approved by evan.weible |
|
QA +1
@Workiva/release-management-p |
todbachman-wf
approved these changes
Jul 26, 2022
| import 'package:analyzer/dart/ast/ast.dart'; | ||
| import 'package:analyzer/dart/ast/token.dart'; | ||
|
|
||
| /// A representation of an namespace directive. |
There was a problem hiding this comment.
#super_minor: there are a few places like this in this file; I assume it's because this used to read "an import directive". 🤷
Suggested change
| /// A representation of an namespace directive. | |
| /// A representation of a namespace directive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: A backpatch for this change exists here for consumers who can't upgrade to analyzer 1.0.0
Having to manually sort imports is tedious. It would be better if we could just run the formatter to receive sorted imports.
I added an
organizeImportsflag to theFormatTool. When set to true, it will also run the file through an import sorter.The import sorter tries to comply with https://dart.dev/tools/linter-rules#directives_ordering