CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug #145

greglittlefield-wf · 2022-05-27T17:05:07Z

Ultimate problem:

For some reason, code using ListSlice sometimes triggers the following dart2js compiler bug: dart-lang/sdk#48762

The error it produces (click to expand)

org-dartlang-app:///packages/collection/src/algorithms.dart@14383+1:
Internal Error: Runtime type information not available for type_variable_local(j:type_variable(quickSort.E)) in (SyntheticLocal(result), local(quickSort#elements), local(quickSort#compare), local(quickSort#start), local(quickSort#end)) for j:method(quickSort).
The compiler is broken.

When compiling the above element, the compiler crashed. It is not
possible to tell if this is caused by a problem in your program or
not. Regardless, the compiler should not crash.

The Dart team would greatly appreciate if you would take a moment to
report this problem at http://dartbug.com/new.

Please include the following information:

* the name and version of your operating system,

* the Dart SDK build number (2.13.4), and

* the entire message you see here (including the full stack trace
  below as well as the source location above).


StdErr:
Unhandled exception:
Assertion failure: Runtime type information not available for type_variable_local(j:type_variable(quickSort.E)) in (SyntheticLocal(result), local(quickSort#elements), local(quickSort#compare), local(quickSort#start), local(quickSort#end)) for j:method(quickSort).
#0      failedAt (package:compiler/src/diagnostics/invariant.dart:49:3)
#1      LocalsHandler.readLocal (package:compiler/src/ssa/locals_handler.dart:354:11)
#2      TypeBuilder._buildEnvironmentForType (package:compiler/src/ssa/type_builder.dart:289:12)
#3      TypeBuilder.analyzeTypeArgumentNewRti (package:compiler/src/ssa/type_builder.dart:207:9)
#4      TypeBuilder.analyzeTypeArgument (package:compiler/src/ssa/type_builder.dart:191:12)
#5      KernelSsaGraphBuilder.visitInstantiation (package:compiler/src/ssa/builder_kernel.dart:5212:24)
#6      Instantiation.accept (package:kernel/ast.dart:6291:44)
#7      KernelSsaGraphBuilder._visitPositionalArguments (package:compiler/src/ssa/builder_kernel.dart:3616:16)
#8      KernelSsaGraphBuilder._visitArgumentsForStaticTarget (package:compiler/src/ssa/builder_kernel.dart:3736:33)
#9      KernelSsaGraphBuilder.visitStaticInvocation (package:compiler/src/ssa/builder_kernel.dart:3820:11)
#10     StaticInvocation.accept (package:kernel/ast.dart:6120:44)
#11     KernelSsaGraphBuilder.visitExpressionStatement (package:compiler/src/ssa/builder_kernel.dart:1765:18)
#12     ExpressionStatement.accept (package:kernel/ast.dart:8462:43)
#13     KernelSsaGraphBuilder.visitBlock (package:compiler/src/ssa/builder_kernel.dart:1731:17)
#14     Block.accept (package:kernel/ast.dart:8518:43)
#15     KernelSsaGraphBuilder._visitInlinedFunction (package:compiler/src/ssa/builder_kernel.dart:6325:30)
#16     KernelSsaGraphBuilder._doInline (package:compiler/src/ssa/builder_kernel.dart:6303:5)
#17     KernelSsaGraphBuilder._tryInlineMethod.doInlining.<anonymous closure> (package:compiler/src/ssa/builder_kernel.dart:5984:11)
#18     KernelSsaGraphBuilder._inlinedFrom.<anonymous closure> (package:compiler/src/ssa/builder_kernel.dart:926:21)
#19     CompilerDiagnosticReporter.withCurrentElement (package:compiler/src/compiler.dart:819:15)
#20     KernelSsaGraphBuilder._inlinedFrom (package:compiler/src/ssa/builder_kernel.dart:924:14)
#21     KernelSsaGraphBuilder._tryInlineMethod.doInlining (package:compiler/src/ssa/builder_kernel.dart:5979:7)
#22     KernelSsaGraphBuilder._tryInlineMethod (package:compiler/src/ssa/builder_kernel.dart:5991:17)
#23     KernelSsaGraphBuilder._pushStaticInvocation (package:compiler/src/ssa/builder_kernel.dart:4939:9)
#24     KernelSsaGraphBuilder.visitStaticInvocation (package:compiler/src/ssa/builder_kernel.dart:3841:5)
#25     StaticInvocation.accept (package:kernel/ast.dart:6120:44)
#26     KernelSsaGraphBuilder.visitExpressionStatement (package:compiler/src/ssa/builder_kernel.dart:1765:18)
#27     ExpressionStatement.accept (package:kernel/ast.dart:8462:43)
#28     KernelSsaGraphBuilder.visitBlock (package:compiler/src/ssa/builder_kernel.dart:1731:17)
#29     Block.accept (package:kernel/ast.dart:8518:43)
#30     KernelSsaGraphBuilder._buildFunctionNode (package:compiler/src/ssa/builder_kernel.dart:1260:23)
#31     KernelSsaGraphBuilder.build.<anonymous closure> (package:compiler/src/ssa/builder_kernel.dart:444:15)
#32     CompilerDiagnosticReporter.withCurrentElement (package:compiler/src/compiler.dart:819:15)
#33     KernelSsaGraphBuilder.build (package:compiler/src/ssa/builder_kernel.dart:429:21)
#34     KernelSsaBuilder.build.<anonymous closure> (package:compiler/src/js_model/js_strategy.dart:502:22)
#35     CompilerTask.measure (package:compiler/src/common/tasks.dart:66:51)
#36     KernelSsaBuilder.build (package:compiler/src/js_model/js_strategy.dart:485:18)
#37     SsaBuilderTask.build (package:compiler/src/ssa/ssa.dart:346:21)
#38     SsaFunctionCompiler.compile (package:compiler/src/ssa/ssa.dart:80:29)
#39     OnDemandCodegenResults.getCodegenResults (package:compiler/src/common/codegen.dart:454:30)
#40     JsBackendStrategy.generateCode (package:compiler/src/js_model/js_strategy.dart:318:43)
#41     KernelCodegenWorkItem.run (package:compiler/src/js_model/js_strategy.dart:452:29)
#42     Compiler.emptyQueue.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:compiler/src/compiler.dart:530:70)
#43     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#44     Compiler.emptyQueue.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:compiler/src/compiler.dart:530:32)
#45     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#46     Compiler.emptyQueue.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:compiler/src/compiler.dart:528:28)
#47     CompilerDiagnosticReporter.withCurrentElement (package:compiler/src/compiler.dart:819:15)
#48     Compiler.emptyQueue.<anonymous closure>.<anonymous closure> (package:compiler/src/compiler.dart:526:18)
#49     CodegenEnqueuer._forEach (package:compiler/src/js_backend/enqueuer.dart:269:12)
#50     CodegenEnqueuer.forEach (package:compiler/src/js_backend/enqueuer.dart:285:5)
#51     Compiler.emptyQueue.<anonymous closure> (package:compiler/src/compiler.dart:522:16)
#52     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#53     Compiler.emptyQueue (package:compiler/src/compiler.dart:521:14)
#54     Compiler.processQueue.<anonymous closure> (package:compiler/src/compiler.dart:547:7)
#55     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#56     Compiler.processQueue (package:compiler/src/compiler.dart:540:14)
#57     Compiler.runCodegenEnqueuer (package:compiler/src/compiler.dart:428:5)
#58     Compiler.generateJavaScriptCode (package:compiler/src/compiler.dart:331:9)
#59     Compiler.compileFromKernel.<anonymous closure> (package:compiler/src/compiler.dart:503:7)
#60     CompilerTask.measureSubtask (package:compiler/src/common/tasks.dart:181:35)
#61     Compiler.compileFromKernel (package:compiler/src/compiler.dart:469:14)
#62     Compiler.runInternal (package:compiler/src/compiler.dart:304:13)
<asynchronous suspension>

How it was fixed:

Remove code using ListSlice (replace .slice with .sublist, which seems to work around the issue in at least some cases.

This seemed safe to do, since the slices weren't being mutated, and only read from.

Testing suggestions:

CI passes (assuming there's good test coverage around this method)

Potential areas of regression:

FYA: @michaelcarter-wf

dart-lang/sdk#48762

aviary-wf · 2022-05-27T17:07:22Z

Security Insights

No security relevant content was detected by automated scans.

Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

tonybathgate-wk · 2022-05-27T19:40:40Z

@greglittlefield-wf I see this failing a format step. But the same step would fail on master. 🤷

greglittlefield-wf · 2022-05-27T20:21:38Z

@tonybathgate-wk Thanks for letting me know! Just pushed a commit to format

tonybathgate-wk · 2022-05-30T16:16:31Z

@greglittlefield-wf

😬 Looks like unit tests are failing now.

…y this works.

jenniferrospad-wf · 2022-06-03T17:57:06Z

lib/src/json_schema/json_schema.dart

@@ -607,7 +607,7 @@ class JsonSchema {
  // When there are 2 possible path to be resolve, traverse both paths.
  JsonSchema _resolveParallelPaths(
    Uri pathUri, // The path being resolved
-    ListSlice<String> fragments, // A slice of fragments being traversed.
+    List<String> fragments, // A slice of fragments being traversed.


nit: is this comment out of date now?

jenniferrospad-wf · 2022-06-03T17:57:06Z

lib/src/json_schema/json_schema.dart

@@ -607,7 +607,7 @@ class JsonSchema {
  // When there are 2 possible path to be resolve, traverse both paths.
  JsonSchema _resolveParallelPaths(
    Uri pathUri, // The path being resolved
-    ListSlice<String> fragments, // A slice of fragments being traversed.
+    List<String> fragments, // A slice of fragments being traversed.


nit: is this comment out of date now?

michaelcarter-wf

+1

tonybathgate-wk · 2022-06-03T23:21:02Z

@Workiva/release-management-p

rmconsole-wf

+1 from RM

Try removing usages of .slice to work around a dart2js compiler bug

8fbb4a0

dart-lang/sdk#48762

rmconsole-wf added the Merge Requirements Unmet label May 27, 2022

greglittlefield-wf marked this pull request as ready for review May 27, 2022 17:19

greglittlefield-wf changed the title ~~Try removing usages of .slice to work around a dart2js compiler bug~~ Removing usages of .slice to work around a dart2js compiler bug May 27, 2022

tonybathgate-wk previously approved these changes May 27, 2022

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels May 27, 2022

greglittlefield-wf changed the title ~~Removing usages of .slice to work around a dart2js compiler bug~~ CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug May 27, 2022

Format

e43a07f

greglittlefield-wf dismissed tonybathgate-wk’s stale review via e43a07f May 27, 2022 20:21

rmconsole-wf added Merge Requirements Unmet and removed Merge Requirements Met labels May 27, 2022

tonybathgate-wk previously approved these changes May 30, 2022

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels May 30, 2022

Fix indices to get unit tests to pass. I don't actually understand wh…

08dc1e0

…y this works.

tonybathgate-wk dismissed their stale review via 08dc1e0 June 2, 2022 23:02

rmconsole-wf added Merge Requirements Unmet and removed Merge Requirements Met labels Jun 2, 2022

tonybathgate-wk added 2 commits June 2, 2022 17:05

remove unnecessary sublist call

12bd23a

revert a format change? idk why my dart format command works differently

e518595

jenniferrospad-wf reviewed Jun 3, 2022

View reviewed changes

michaelcarter-wf previously approved these changes Jun 3, 2022

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels Jun 3, 2022

update comment to match List type

79d1318

tonybathgate-wk dismissed michaelcarter-wf’s stale review via 79d1318 June 3, 2022 21:02

rmconsole-wf added Merge Requirements Unmet and removed Merge Requirements Met labels Jun 3, 2022

jenniferrospad-wf approved these changes Jun 3, 2022

View reviewed changes

rmconsole-wf added Merge Requirements Met and removed Merge Requirements Unmet labels Jun 3, 2022

rmconsole-wf added the RM Ready label Jun 3, 2022

rm-astro-wf merged commit 80b3ce8 into master Jun 3, 2022

rmconsole-wf approved these changes Jun 3, 2022

View reviewed changes

rm-astro-wf deleted the no-slice branch June 3, 2022 23:21

rmconsole-readonly-wk mentioned this pull request Jun 6, 2022

RM-137681 Release json_schema 4.0.3 #146

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug #145

CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug #145

greglittlefield-wf commented May 27, 2022 •

edited

Loading

aviary-wf commented May 27, 2022

tonybathgate-wk commented May 27, 2022

greglittlefield-wf commented May 27, 2022

tonybathgate-wk commented May 30, 2022

jenniferrospad-wf Jun 3, 2022

jenniferrospad-wf Jun 3, 2022

michaelcarter-wf left a comment

tonybathgate-wk commented Jun 3, 2022

rmconsole-wf left a comment

CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug #145

CPLAT-17467 Remove usages of .slice to work around a dart2js compiler bug #145

Conversation

greglittlefield-wf commented May 27, 2022 • edited Loading

Ultimate problem:

How it was fixed:

Testing suggestions:

Potential areas of regression:

aviary-wf commented May 27, 2022

Security Insights

Action Items

tonybathgate-wk commented May 27, 2022

greglittlefield-wf commented May 27, 2022

tonybathgate-wk commented May 30, 2022

jenniferrospad-wf Jun 3, 2022

Choose a reason for hiding this comment

jenniferrospad-wf Jun 3, 2022

Choose a reason for hiding this comment

michaelcarter-wf left a comment

Choose a reason for hiding this comment

tonybathgate-wk commented Jun 3, 2022

rmconsole-wf left a comment

Choose a reason for hiding this comment

greglittlefield-wf commented May 27, 2022 •

edited

Loading