CPLAT-4107 Remove getJsProps() #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
evanweible-wf
force-pushed
the
remove_getJsProps
branch
from
b94347d to
bae88e5
Compare
evanweible-wf
added
the
dart2
|
LGTM, will review once the override is removed |
corwinsheahan-wf
approved these changes
Feb 8, 2019
|
QA +1 All tests passed in CI @Workiva/release-management-pp |
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dependent on Workiva/react-dart#153 - should be released in
react-dart v4.6.0Ultimate problem:
getJsProps()was deprecated in 1.x and needs to be removed in 2.0.0.How it was fixed:
Remove it and update usages to the new
unconvertJsProps()method in react-dart.Testing suggestions:
Potential areas of regression:
getJsProps(), should all be tested via unit tests