Skip to content

Test consume react-dart dual support (force React 18) #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Test consume react-dart dual support (force React 18) #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31835eb
Point to react-dart FED-3283-dual-support for testing
greglittlefield-wf Apr 17, 2025
18f217f
Swap out all React scripts with React 18 version
greglittlefield-wf Apr 17, 2025
136071b
Point to WIP dual-version RTL branch for testing
greglittlefield-wf Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ and add an HTML element with a unique identifier where you’ll mount your OverR
// OverReact component render() output will show up here.
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<!-- NOTE: "index" should correspond to the
name of the `.dart` file that contains your `main()` entrypoint. -->
Expand Down
3 changes: 1 addition & 2 deletions app/over_react_redux/todo_client/test/unit/_templates/react_components_test_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<!-- See: https://pub.dev/packages/test_html_builder -->
<html>
<head>
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="packages/todo_client/src/test_fixtures/mock_js_objects.js"></script>
<script src="https://unpkg.com/@material-ui/core/umd/material-ui.development.js" crossorigin="anonymous"></script>

Expand Down
3 changes: 1 addition & 2 deletions app/over_react_redux/todo_client/test/unit/_templates/react_test_template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
<!-- See: https://pub.dev/packages/test_html_builder -->
<html>
<head>
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

{{testScript}}

Expand Down
3 changes: 1 addition & 2 deletions app/over_react_redux/todo_client/web/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@

<div id="todo-container"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="https://unpkg.com/@material-ui/core/umd/material-ui.development.js" crossorigin="anonymous"></script>

<!-- Serve compiled output. -->
Expand Down
3 changes: 1 addition & 2 deletions example/boilerplate_versions/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="main.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions example/builder/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="main.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions example/context/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="main.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions example/error_boundary/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react_prod.js"></script>
<script src="packages/react/react_dom_prod.js"></script>
<script src="packages/react/js/react.min.js"></script>

<script type="application/javascript" defer src="main.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions example/hooks/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="main.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions example/suspense/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react_prod.js"></script>
<script src="packages/react/react_dom_prod.js"></script>
<script src="packages/react/js/react.min.js"></script>
<script>
const defaultMessageContext = React.createContext('default context value');
window.TestJsComponent = React.forwardRef(function (props, ref) {
Expand Down
12 changes: 12 additions & 0 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,15 @@ workiva:
core_checks:
version: 1
react_boilerplate: disabled


dependency_overrides:
react:
git:
url: https://github.com/Workiva/react-dart.git
ref: FED-3283-dual-support
react_testing_library:
git:
url: https://github.com/Workiva/react_testing_library.git
ref: r18-dual-version-spike

3 changes: 1 addition & 2 deletions test/over_react_component_declaration_non_null_safe_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Unit Tests - over_react component_declaration</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="packages/react_testing_library/js/react-testing-library.js"></script>

<link rel="x-dart-test" href="over_react_component_declaration_non_null_safe_test.dart">
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_component_declaration_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Unit Tests - over_react component_declaration</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="packages/react_testing_library/js/react-testing-library.js"></script>

<link rel="x-dart-test" href="over_react_component_declaration_test.dart">
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_component_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Tests - over_react component</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="packages/react_testing_library/js/react-testing-library.js"></script>
<script>
const defaultMessageContext = React.createContext('default context value');
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_dom_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Unit Tests - over_react.react.dom library</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<link rel="x-dart-test" href="over_react_dom_test.dart">
<script src="packages/test/dart.js"></script>
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_prod_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Unit Tests - react.dart prod</title>
<!-- javascript -->
<script src="packages/react/react_prod.js"></script>
<script src="packages/react/react_dom_prod.js"></script>
<script src="packages/react/js/react.min.js"></script>
<script src="packages/react_testing_library/js/react-testing-library.js"></script>

<script>
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_redux_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Tests - over_react_redux</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<link rel="x-dart-test" href="over_react_redux_test.dart">
<script src="packages/test/dart.js"></script>
Expand Down
3 changes: 1 addition & 2 deletions test/over_react_util_test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
<head>
<title>OverReact Unit Tests - over_react util</title>
<!-- javascript -->
<script src="packages/react/react_with_addons.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>
<script src="packages/react_testing_library/js/react-testing-library.js"></script>

<script>
Expand Down
3 changes: 1 addition & 2 deletions web/component1/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ <h2>Component That Throws an Uncaught Error</h2>
</div>
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<!--un comment to serve in Dart 1-->
<!--<script type="application/dart" src="index.dart"></script>-->
Expand Down
3 changes: 1 addition & 2 deletions web/component2/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,7 @@ <h2>Ref Examples</h2>
</div>
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<!--un comment to serve in Dart 1-->
<!--<script type="application/dart" src="index.dart"></script>-->
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/advanced/examples/flux_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/advanced/examples/influx_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/advanced/examples/redux_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/simple/examples/flux_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/simple/examples/influx_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/flux_to_redux/simple/examples/redux_implementation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/over_react_redux/examples/dev_tools/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
Loading...
</div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/over_react_redux/examples/multiple_stores/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down
3 changes: 1 addition & 2 deletions web/over_react_redux/examples/simple/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@
<body>
<div id="content"></div>

<script src="packages/react/react.js"></script>
<script src="packages/react/react_dom.js"></script>
<script src="packages/react/js/react.dev.js"></script>

<script type="application/javascript" defer src="index.dart.js"></script>
</body>
Expand Down