Skip to content

Revert "Remove binding for nonexistent SyntheticDataTransfer class" #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

Revert "Remove binding for nonexistent SyntheticDataTransfer class" #154

merged 1 commit into from
Feb 7, 2019

Conversation

evanweible-wf
Copy link
Collaborator

Reverts #151 - it results in some typing errors like so:

Unhandled exception:
type 'JSObjectImpl' is not a subtype of type 'DataTransfer' of 'dt' where
JSObjectImpl is from dart:js
DataTransfer is from dart:html
#0      syntheticDataTransferFactory (package:react/react_client.dart:746:65)
#1      syntheticMouseEventFactory (package:react/react_client.dart:784:30)
#2      _convertEventHandlers.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:react/react_client.dart:561:35)

This commit had not yet been released, so for the time being (in order to get #153 through) we are going to revert. We can circle back to fix this by finding a way to construct a real DataTransfer object using JS.

@greglittlefield-wf @aaronlademann-wf @kealjones-wk @corwinsheahan-wf

@greglittlefield-wf
Copy link
Collaborator

+1

@greglittlefield-wf greglittlefield-wf merged commit 31be823 into Workiva:master Feb 7, 2019
@evanweible-wf evanweible-wf deleted the revert-151-data-transfer-dart2js-fix branch February 7, 2019 04:07
greglittlefield-wf added a commit that referenced this pull request Oct 10, 2019
@greglittlefield-wf
Fix dataTransfer RTE take 2: work around issue in #154 that necessita…
4a79540 
…ted revert of #153
@greglittlefield-wf greglittlefield-wf mentioned this pull request Oct 10, 2019
Merged
greglittlefield-wf added a commit that referenced this pull request Oct 10, 2019
@greglittlefield-wf
Fix dataTransfer RTE take 2: work around issue in #154 that necessita…
262552b 
…ted revert of #151
@greglittlefield-wf greglittlefield-wf mentioned this pull request Nov 10, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corwinsheahan-wf corwinsheahan-wf corwinsheahan-wf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evanweible-wf @greglittlefield-wf @corwinsheahan-wf