CPLAT-8035 Implement/Expose useEffect Hook #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneyjodon-wk
changed the base branch from
CPLAT-4309-react-hooks
to
CPLAT-8034-usestate-hook
kealjones-wk
requested changes
Nov 7, 2019
# Conflicts: # example/test/function_component_test.dart
# Conflicts: # example/test/function_component_test.dart
kealjones-wk
previously requested changes
Nov 20, 2019
greglittlefield-wf
changed the base branch from
CPLAT-8034-usestate-hook
to
5.2.0-wip
greglittlefield-wf
requested changes
Dec 2, 2019
# Conflicts: # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
| @@ -144,7 +144,7 @@ void useEffect(dynamic Function() sideEffect, [List<Object> dependencies]) { | |||
| if (result is Function) { | |||
| return allowInterop(result); | |||
| } | |||
| return null; | |||
| return jsUndefined; | |||
There was a problem hiding this comment.
Could we add a comment saying why undefined is needed?
aaronlademann-wf
previously requested changes
Dec 3, 2019
Comment on lines
+152
to
+153
| if (dependencies != null) { | ||
| return React.useEffect(wrappedSideEffect, dependencies); |
There was a problem hiding this comment.
Is it ok / reasonably efficient to pass in an empty list here?
If not, we should probably check .isNotEmpty in addition to != null.
There was a problem hiding this comment.
Yes, passing an empty list is used if you just want to run an effect and clean it up only once (on mount and unmount)
aaronlademann-wf
force-pushed
the
5.3.0-wip
branch
from
b7cab0d to
d65d845
Compare
# Conflicts: # example/test/function_component_test.dart
3 tasks
greglittlefield-wf
dismissed stale reviews from kealjones-wk and aaronlademann-wf
feedback addressed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support useEffect hook in react-dart
Changes
useEffectfunctionPlease review: @kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk