CPLAT-8038 Implement/Expose useCallback Hook #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sydneyjodon-wk
changed the base branch from
master
to
CPLAT-8034-usestate-hook
kealjones-wk
approved these changes
Nov 20, 2019
lib/hooks.dart
Outdated
Comment on lines
107
to
110
| /// Note there are two rules for using Hooks (<https://reactjs.org/docs/hooks-rules.html>): | ||
| /// | ||
| /// * Only call Hooks at the top level. | ||
| /// * Only call Hooks from inside a [DartFunctionComponent]. |
There was a problem hiding this comment.
#nit, we can do this later and not a big deal, and i only just realized this after reviewing all these, that maybe this should be formatted like this:
/// > __Note:__ there are two [rules for using Hooks](https://reactjs.org/docs/hooks-rules.html):
/// >
/// > * Only call Hooks at the top level.
/// > * Only call Hooks from inside a [DartFunctionComponent].
There was a problem hiding this comment.
I updated this in a couple places and I'll make sure the rest are updated in the overall hooks branch
greglittlefield-wf
changed the base branch from
CPLAT-8034-usestate-hook
to
5.2.0-wip
| react_test_utils.Simulate.click(incrementDeltaButtonRef); | ||
| }); | ||
|
|
||
| test('callback stays the same if state not in dependency list', () { |
There was a problem hiding this comment.
Nice tests here!
|
+10 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support useCallback hook in react-dart
Changes
useCallbackfunctionPlease review: @kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk