Implement React.memo #252
Merged
Implement React.memo #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlademann-wf
force-pushed
the
5.4.0/memo
branch
from
e63bee1 to
e3bdc7a
Compare
Contributor
joebingham-wk
left a comment
joebingham-wk
left a comment
There was a problem hiding this comment.
A few unused imports that were probably just auto-pulled in while writing the test, but otherwise everything looked great!
| @@ -0,0 +1,163 @@ | |||
| import 'dart:async'; | |||
Contributor
There was a problem hiding this comment.
#nit unused import
Suggested change
| import 'dart:async'; |
| @@ -0,0 +1,163 @@ | |||
| import 'dart:async'; | |||
| import 'dart:developer'; | |||
Contributor
There was a problem hiding this comment.
#nit unused import
Suggested change
| import 'dart:developer'; |
| import 'dart:developer'; | ||
| @TestOn('browser') | ||
| import 'dart:html'; | ||
| import 'dart:js_util'; |
Contributor
There was a problem hiding this comment.
#nit unused import
Suggested change
| import 'dart:js_util'; |
greglittlefield-wf
approved these changes
Jan 31, 2020
| @override | ||
| render() { | ||
| return react.div( | ||
| {'key': 'mtdw'}, |
Collaborator
There was a problem hiding this comment.
#nit this key is unnecessary
| return react.div( | ||
| {'key': 'mtdw'}, | ||
| MemoTest({ | ||
| 'localCount': this.state['localCount'], |
Collaborator
There was a problem hiding this comment.
#nit As per the Dart style guide, avoid unnecessary this
….com:cleandart/react-dart into 5.4.0/memo
Contributor
joebingham-wk
left a comment
joebingham-wk
left a comment
There was a problem hiding this comment.
Used the profiler to verify that the props are memoized and the time to commit decreases.
QA +1
# Conflicts: # lib/react_client/react_interop.dart
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
React.memoin the Dart API, along with examples and tests.FYA: @greglittlefield-wf @sydneyjodon-wk @joebingham-wk