-
Notifications
You must be signed in to change notification settings - Fork 68
CPLAT-12469 Update to React 17 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
952afbe
upgrade to react 17rc
kealjones-wk b44f3da
Bump to 17.0.0-rc.1
joebingham-wk 92a1aa0
Bump react DOM
joebingham-wk a6c1e0d
fix PropTypes react 17
kealjones-wk 647dfa9
Merge branch 'master' into testing-react-17-rc
kealjones-wk d4f429d
Bump to 17.0.0-rc.3
sydneyjodon-wk aac076c
Build
sydneyjodon-wk af09134
Merge branch 'master' into testing-react-17-rc
sydneyjodon-wk e03966a
Re-build after merge
sydneyjodon-wk def6f61
Update display name implementation
sydneyjodon-wk 8aa7feb
Bump to released react 17.0.0
sydneyjodon-wk 1ef1196
Remove deprecated APIs
sydneyjodon-wk 3ae0140
Add compile-time check
sydneyjodon-wk 2978197
Update test
sydneyjodon-wk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that I opted for this route to prevent breakages in the
PropTypes
api, specifically theresetWarningCache()
react has opted to build in their own "prop-types" rather than using the external package. Currently react does not provide a way to reset the warning cache of itself, which we use quite a bit in tests, so i opted to use the external package. It is also unclear what the future holds for prop-types in general so the external package is a safer bet for long term support as the React team feels that Typescript on its own provides most of the prop type checks statically, unfortunately dart types do not support things such as Literal Types, Tuples, Unions, Optional/Required fields (i mean they kinda do but not as nicely), etc...