Skip to content

RM-93030 Release react-dart 6.0.0 #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 91 commits into from
Jan 15, 2021
Merged

RM-93030 Release react-dart 6.0.0 #285

merged 91 commits into from
Jan 15, 2021

Conversation

joebingham-wk
Copy link
Collaborator

@joebingham-wk joebingham-wk commented Nov 9, 2020

This stable, major release of react includes:

ReactJS 17.x Support

The underlying .js files provided by this package are now ReactJS version 17.0.1.


ReactJS 17 Breaking Changes

Source: https://reactjs.org/blog/2020/08/10/react-v17-rc.html#other-breaking-changes

React 17 includes some breaking changes, but rather than being large API removals, they are mostly subtle behavior changes of existing APIs. Please refer to their blog post for all behavior changes.

Dart API Breaking Changes

Dart API Removals

APIs that were removed were:

  1. those that were no longer in use. This was done in CPLAT-12469 Update to React 17 #277.
  2. part of the changes to the SyntheticEvent class, which are described in "Other Breakages" below.

All other APIs slated for removal in 6.0.0 were bumped to 7.0.0 here in order to keep the migration to 6.0.0 as simple as possible.

Other Breakages

Breakage Migration path
SyntheticEvent classes (of all types) cannot be invoked. Use create{X}SyntheticEvent. See the utilities here.
SyntheticEvent classes (of all types) cannot be type checked with is. Use SyntheticEvent.is{X}Event instead. See the utilities here.
SyntheticEvent.isFormEvent was removed because React.js does not have a SyntheticFormEvent, and via duck typing, it will always have the same shape as SyntheticEvent itself. Check the event type property instead for one of the relevant types. Note: the type property on the event instance excludes the on prefix.

kealjones-wk and others added 30 commits August 11, 2020 08:45
* master: (46 commits)
  react 5.6.0
  Add missing stuff to 5.5.1 changelog entry
  Don't check dartfmt when using the dev build of Dart
  Remove print statement
  Fix forwardRef2/useImperativeHandle typing, update tests to use forwardRef2 and test all ref types
  Rename test utility
  react 5.5.1
  Add regression test for passing forwardRef2 into memo2
  Reinstate tests for memo and forwardRef
  Address CR feedback related to comments
  useImperativeHandle should not throw if ref is null
  Run npm audit fix, build JS sources
  Remove unused ref un-conversion logic
  Improve doc comment
  Cleanup / comments
  Format
  Fix lints
  Clean up test case objects
  Improve forwardRef and base ref tests, fix chaining of converted refs
  Relocate similar event handler unconversion logic
  ...
# Conflicts:
#	lib/react.js.map
#	lib/react_with_addons.js.map
[6.0.0] Resolve peerDependencies warning for react-redux
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Note: dev channel CI failures are expected (see #298)

Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Additional commits look good
  • CI is passing
  • JS assets are up to date

+10

@greglittlefield-wf greglittlefield-wf changed the title RM-93030 Release react 6.0.0 RM-93030 Release react-dart 6.0.0 Jan 15, 2021
@ghost
Copy link

ghost commented Jan 15, 2021

Security +1

@greglittlefield-wf
Copy link
Collaborator

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@greglittlefield-wf
Copy link
Collaborator

semver +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants