Fix isMouseEvent returning false for simulated context menu events #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesNo changes to the public API found for commit f3f880f Showing results for f3f880f
Last edited UTC Jan 27 at 16:45:09 |
greglittlefield-wf
requested review from
sydneyjodon-wk,
aaronlademann-wf and
joebingham-wk
greglittlefield-wf
changed the title
joebingham-wk
approved these changes
Jan 27, 2021
|
@aviary-wf try again please |
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
isMouseEventwas incorrectly returningfalsefor events created viaSimulate.contextMenu.It looks like we were missing type-checking test coverage for contextmenu events (I checked to see if any more were missing, but contextmenu was the only one).
Solution
typestring checks inisMouseEventso that it returnstruefor simulated context menu eventsQA Instructions