Temporarily disable the mockito builder for better build perf #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mockito builder is only needed for NNBD code and the default behavior is for it to run on every `.dart` file and fully resolve each of those files, which is slow. **Disabling this builder should improve local and CI build times.**
Security Insights(2) Vulnerable direct dependencies were detectedansi-regex < 5.0.1 via yarn.lockglob-parent < 5.1.2 via yarn.lockAction Items
Questions or Comments? Reach out on Slack: #support-infosec. |
robbecker-wf
approved these changes
Feb 24, 2022
|
QA+1 CI Passes |
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why
This batch temporarily disables the mockito builder because it is only
needed for NNBD code and the default behavior is for it to run on every
.dartfile and fully resolve each of those files, which is slow.Disabling this builder should improve local and CI build times.
Testing
These changes should only disable a builder that is already not generating
anything for packages that have not yet migrated to null-safety. For that
reason, code review of the modification to the
build.yamland passing CIshould be sufficient testing.
More Info
This batch change is a part of a larger Client Platform effort to update our
Dart dependencies and unblock us from upgrading to the latest Dart SDK.
More info can be found here: https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
If you have any questions or comments, please comment on this PR or reach
out to
#support-client-platon Slack.Created by Sourcegraph batch change
Workiva/disable_mockito_builder.