RM-138703 Release react-dart 6.1.6 (Publish JS bundles to Workiva CDN) #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security Insights(2) Vulnerable direct dependencies were detectedglob-parent < 5.1.2 via yarn.lockminimist < 1.2.6 via yarn.lockAction Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
wk-cdn
branch
4 times, most recently
from
8745c85 to
a55b64d
Compare
aaronlademann-wf
force-pushed
the
wk-cdn
branch
from
a55b64d to
dc397a9
Compare
aaronlademann-wf
changed the title
greglittlefield-wf
requested changes
Mar 30, 2022
greglittlefield-wf
requested changes
Mar 30, 2022
greglittlefield-wf
approved these changes
Mar 30, 2022
Collaborator
greglittlefield-wf
left a comment
greglittlefield-wf
left a comment
There was a problem hiding this comment.
- Changes look good
- CDN artifact contains all JS files and source maps
- Files published to dev CDN successfully
- Skynet failed on test branch when some JS assets were missing: https://wf-skynet-hrd.appspot.com/apps/test/smithy/3503896/1/react-dart/validate_cdn_artifact#summary
- Skynet passes
- Rosie release info looks good
+10
Collaborator
Author
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've moved this package within the Workiva org, we should publish the JS bundles to our CDN so that Workiva customers get assets cached based on the react package version, not the Workiva application version.