Skip to content

Fix default key prefix #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Fix default key prefix #54

merged 1 commit into from
Jul 30, 2022

Conversation

SQKo
Copy link
Contributor

@SQKo SQKo commented Jul 26, 2022

A minor fix, It was mistyped "reach" instead of "react"

It was mistyped "reach" instead of "react"
@SQKo SQKo requested a review from WyriHaximus as a code owner July 26, 2022 08:10
@WyriHaximus WyriHaximus added this to the 4.3.0 milestone Jul 26, 2022
@WyriHaximus
Copy link
Owner

@SQKo Cool thanks, which PHP version do you use? Because before releasing I might do a bump to only PHP 8 or 8.1, unless you need it on a lower version.

@SQKo
Copy link
Contributor Author

SQKo commented Jul 29, 2022

Doesn't matter to me, since the prefix can still be set manually. I just apparently noticed it when doing some debugging.

@WyriHaximus
Copy link
Owner

Ok great, will put it into 5.0.0 in that case, thanks 👍 .

P.S. I like the work you've been doing with this.

@WyriHaximus WyriHaximus merged commit 6829a61 into WyriHaximus:master Jul 30, 2022
@SQKo SQKo deleted the patch-1 branch July 31, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants