Skip to content

Feature/rb 56 check deads#38

Merged
Saverio976 merged 30 commits intodevfrom
feature/RB-56-checkDeads
Oct 3, 2023
Merged

Feature/rb 56 check deads#38
Saverio976 merged 30 commits intodevfrom
feature/RB-56-checkDeads

Conversation

@kw4ntiq
Copy link
Copy Markdown
Collaborator

@kw4ntiq kw4ntiq commented Oct 2, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)

  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@kw4ntiq kw4ntiq requested a review from KitetsuK October 2, 2023 18:21
@kw4ntiq kw4ntiq requested a review from guillaumeAbel October 2, 2023 18:42
guillaumeAbel
guillaumeAbel requested changes Oct 2, 2023
View reviewed changes
@kw4ntiq kw4ntiq self-assigned this Oct 3, 2023
@kw4ntiq kw4ntiq added the enhancement New feature or request label Oct 3, 2023
kw4ntiq and others added 13 commits October 3, 2023 15:29
@kw4ntiq
GAME-LOGIC: Add funcitonnal EntityDeathFunction
e80cd94 
MINOR
@github-actions
FORMAT-AUTO: automatic format on pull request #38
d58aad4
@kw4ntiq
GAME-LOGIC: Add test
cf12c46
@kw4ntiq
CLIENT-GAME: Fix test func
c99020e
@github-actions
FORMAT-AUTO: automatic format on pull request #38
b10872d
@kw4ntiq
GAME-LOGIC: Add enemy test
10d5d6c
@kw4ntiq
Merge branch 'feature/RB-56-checkDeads' of github.com:X-R-G-B/R-Bus i…
9b7614b 
…nto feature/RB-56-checkDeads
@github-actions
FORMAT-AUTO: automatic format on pull request #38
67ad627
@kw4ntiq
GAME-LOGIC: Add debug
cf6bf99
@github-actions
FORMAT-AUTO: automatic format on pull request #38
e883a93
@guillaumeAbel
Merge branch 'dev' into feature/RB-56-checkDeads
e623b10
@kw4ntiq
Merge branch 'dev' into feature/RB-56-checkDeads
1a778a6
@kw4ntiq
Merge branch 'feature/RB-56-checkDeads' of github.com:X-R-G-B/R-Bus i…
98a7736 
…nto feature/RB-56-checkDeads
Saverio976
Saverio976 requested changes Oct 3, 2023
View reviewed changes
@kw4ntiq kw4ntiq marked this pull request as draft October 3, 2023 19:47
@kw4ntiq kw4ntiq marked this pull request as ready for review October 3, 2023 20:52
Saverio976
Saverio976 approved these changes Oct 3, 2023
View reviewed changes
src/ECS/ECSCustomTypes.hpp

#pragma once

// all values are in percentage of the screen
Copy link
Copy Markdown
Collaborator

@Saverio976 Saverio976 Oct 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi supprimer ?

@Saverio976 Saverio976 merged commit 6c8c2e2 into dev Oct 3, 2023
@Saverio976 Saverio976 deleted the feature/RB-56-checkDeads branch October 10, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saverio976 Saverio976 Saverio976 approved these changes

@KitetsuK KitetsuK KitetsuK approved these changes

@guillaumeAbel guillaumeAbel guillaumeAbel approved these changes

Assignees

@kw4ntiq kw4ntiq

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kw4ntiq @Saverio976 @KitetsuK @guillaumeAbel