Skip to content

Fix/rb 66 sound effect still playing#47

Merged
guillaumeAbel merged 29 commits intodevfrom
fix/RB-66-Sound-effect-still-playing
Oct 9, 2023
Merged

Fix/rb 66 sound effect still playing#47
guillaumeAbel merged 29 commits intodevfrom
fix/RB-66-Sound-effect-still-playing

Conversation

@kw4ntiq
Copy link
Copy Markdown
Collaborator

@kw4ntiq kw4ntiq commented Oct 4, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)
  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@kw4ntiq kw4ntiq self-assigned this Oct 4, 2023
@kw4ntiq kw4ntiq added the bug Something isn't working label Oct 4, 2023
@kw4ntiq kw4ntiq marked this pull request as draft October 4, 2023 17:15
@kw4ntiq kw4ntiq marked this pull request as ready for review October 9, 2023 16:07
@kw4ntiq kw4ntiq requested a review from romainpanno October 9, 2023 16:17
@guillaumeAbel guillaumeAbel merged commit 8c43ac0 into dev Oct 9, 2023
@Saverio976 Saverio976 deleted the fix/RB-66-Sound-effect-still-playing branch October 10, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants