Skip to content

Feature/rb 92 function receive enemy death#53

Merged
romainpanno merged 18 commits intodevfrom
feature/RB-92-function-receive-enemy-death
Oct 10, 2023
Merged

Feature/rb 92 function receive enemy death#53
romainpanno merged 18 commits intodevfrom
feature/RB-92-function-receive-enemy-death

Conversation

@guillaumeAbel
Copy link
Copy Markdown
Collaborator

@guillaumeAbel guillaumeAbel commented Oct 6, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Norm of the code has been respected
  • In what state is your pull request?
  • Ready to merge / Waiting a reviwer to see my work.
  • Work In Progress (WIP) / My work is not finish but i want daily reviews. (Draft)
  • CI Review / I want to see what the CI thinks of my work.
  • Need feedback / Just to have feedback on what i produced. (May not be merged)
  • What kind of change does this PR introduce? (You can choose multiple)
  • Bug fix
  • Feature request
  • New / Updated documentation
  • Testing CI ( Make the pull request in draft mode)
  • What is the current behavior? (link an issue based on the kind of change this pr introduce)

  • What is the new behavior (if this is a feature change)?

  • Other information:

@guillaumeAbel guillaumeAbel self-assigned this Oct 6, 2023
@guillaumeAbel guillaumeAbel added the enhancement New feature or request label Oct 6, 2023
@guillaumeAbel
Copy link
Copy Markdown
Collaborator Author

actually not compiling, cause the bug @TTENSHII is actually fixing, Enemy component is copied, but it cannot be cause it have a const value

@romainpanno romainpanno dismissed Saverio976’s stale review October 10, 2023 20:09

you wasn't here at the good time

@romainpanno romainpanno merged commit 1f41ba2 into dev Oct 10, 2023
@Saverio976 Saverio976 deleted the feature/RB-92-function-receive-enemy-death branch October 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants