Skip to content

Add/Update some Test Files + fix bugs#484

Closed
alain91 wants to merge 4 commits into
XOOPS:masterfrom
alain91:alain350
Closed

Add/Update some Test Files + fix bugs#484
alain91 wants to merge 4 commits into
XOOPS:masterfrom
alain91:alain350

Conversation

@alain91

@alain91 alain91 commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@alain91

alain91 commented Apr 21, 2016

Copy link
Copy Markdown
Contributor Author

I don't understand the error with GrouppermHandlerTest redeclation because there is only one such name.

I have changed the $x variable name

but at the present time the usage of \XoopsBaseConfig implies static method call => maybe I would be necessary to modify the behaviour with a Singleton pattern ?

@alain91

alain91 commented Apr 21, 2016

Copy link
Copy Markdown
Contributor Author

I have changed the case in filename GrouppermHandler and the travis job use the old one.

@geekwright

Copy link
Copy Markdown
Contributor

Please ignore the line notes. Codacy added those -- I've changed the settings to turn those off. Sorry.

@geekwright

Copy link
Copy Markdown
Contributor

There were a couple of filename case issues where there were two entries in the index with different names, but on Windows, the names would resolve to the same actual file.

Once that was cleared up, there were a couple of other little issues.

Looks good, thanks!

@geekwright geekwright closed this Apr 21, 2016
@alain91 alain91 deleted the alain350 branch April 22, 2016 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants