Skip to content

feat: add 'force_forward' field to request #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

cindyyan317
Copy link
Contributor

Clio will forward the request to rippled when 'ledger_index' is 'current' or 'closed'. When 'ledger_index' is 'validated' or other valid number input, there is no way to forward it to rippled.

For purpose of debugging, we allow admin to send request to its p2p rippled with 'force_forward' being true.

add tests

change include

fix unittest
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.90%. Comparing base (0ede0ed) to head (624632d).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/rpc/common/impl/ForwardingProxy.hpp 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1647      +/-   ##
===========================================
- Coverage    69.91%   69.90%   -0.01%     
===========================================
  Files          260      260              
  Lines         9971     9976       +5     
  Branches      5497     5500       +3     
===========================================
+ Hits          6971     6974       +3     
- Misses        1587     1588       +1     
- Partials      1413     1414       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me 👍 just one style remark 🔢

Copy link
Collaborator

@godexsoft godexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cindyyan317 cindyyan317 merged commit 0282504 into XRPLF:develop Sep 17, 2024
16 of 17 checks passed
@cindyyan317 cindyyan317 deleted the force_forward branch September 17, 2024 10:42
kuznetsss pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants