-
Notifications
You must be signed in to change notification settings - Fork 62
custom dimensions for a multimode density matrix #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ction -fixed the code style according to PEP8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should go in the 0.23 section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will fix CHANGELOG.md
I have a question. Although, I didn't change function hermite_multidimensional in _hermite_multidimensional.py, it compatible with a list cutoff by design. Should I change the documentation of this function?
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Context:
'cutoff' argument for the 'density_matrix(mu, cov, post_select, normalize, cutoff, hbar)' function from 'fock_tensors.py' is the same for all modes
Description of the Change:
Added support of the 'list' type of 'cutoff' argument for the 'density_matrix(mu, cov, post_select, normalize, cutoff, hbar)' function from 'fock_tensors.py'. It enables to perform larger simulations.
Example: 4 bosonic modes
Hilbert space dimensions 20 for each mode => ~380 GB of RAM for a density matrix.
Hilbert space dimensions 20 for 2 main and 3 for auxiliary modes => 200 MB of RAM for a density matrix.
Benefits:
Enables users to choose different Hilbert space dimensions for different modes of a density matrix. It can be helpful for simulations with a large number of modes.
Possible Drawbacks:
None
Related GitHub Issues:
None