[AIE2P] Enable stack size section for start up code. #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagarMaheshwari99
requested review from
abhinay-anubola,
abnikant,
andcarminati,
F-Stuckmann,
gbossu,
katerynamuts,
khallouh,
konstantinschwarz,
martien-de-jong,
niwinanto and
stephenneuendorffer
as code owners
konstantinschwarz
approved these changes
Jun 24, 2025
| @@ -3,7 +3,8 @@ | |||
| # See https://llvm.org/LICENSE.txt for license information. | |||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
| # | |||
| # (c) Copyright 2024 Advanced Micro Devices, Inc. or its affiliates | |||
| # (c) Copyright 2024-2025 Advanced Micro Devices, Inc. or its affiliates | |||
|
|
|||
There was a problem hiding this comment.
I see that we are reusing aie2 startup in aie2p (including asm files). They are similar but not the same, so do you think it is better to have a clear separation here?
There was a problem hiding this comment.
crt1.cc is supposed to be portable. only crt0 contains the arch-dependent stuff of setting up the initial stack pointer and calling _main_init. Perhaps we can move crt1.cc to a 'common' aie directory.
There was a problem hiding this comment.
We can take this up when we finalize code for future archs.
| (void)val; | ||
| done(); | ||
| } | ||
| void _Exit(int) { done(); } |
There was a problem hiding this comment.
This will now get name mangled. _Exit is a defined libc symbol,
There was a problem hiding this comment.
but it is inside extern "C"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.