Skip to content

[WIP] core/state: remove toAddr helper in tests #22772 #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: dev-upgrade
Choose a base branch
from
Open

[WIP] core/state: remove toAddr helper in tests #22772 #1203

wants to merge 11 commits into from

Conversation

gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jul 9, 2025

Proposed changes

Ref: ethereum#22772

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

rjl493456442 and others added 11 commits July 11, 2025 12:36
@rjl493456442 @gzliudan
core, trie: decode the value for storage dump ethereum#19943
37c534d 
* core, trie: decode the value for storage dump

* core/state: address comment
@gzliudan
core/state: fix staticcheck warnings ethereum#20357
c276516
@jsvisa @holiman
@fjl @gzliudan
eth: add debug_accountRange API ethereum#19645
01717d9 
This new API allows reading accounts and their content by address range.

Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Felix Lange <[email protected]>
@holiman @AlexeyAkhunov @gzliudan
core/state: include zero-address in state dump if present ethereum#21038
065ef34 


* Include 0x0000 address into the dump if it is present

* core/state: go fmt

Co-authored-by: Alexey Akhunov <[email protected]>
@holiman @gzliudan
core/state: abort commit if read errors have occurred ethereum#21039
a38bba6 
This finally adds the error check that the documentation of StateDB.dbErr
promises to do. dbErr was added in 9e5f03b (June 2017), and the check was
already missing in that commit. We somehow survived without it for three years.
@gzliudan
core/state: avoid statedb.dbErr due to emptyCode ethereum#21051
2383b6b
@karalabe @gzliudan
core/state: make GetCodeSize mirror GetCode implementation wise ether…
b22ed61 
…eum#21056
@gzliudan
core/state: add state transition tool for testing ethereum#20958
a785e63
@gzliudan
core/state: fix some comments ethereum#21450
e02624a
@holiman @gzliudan
core/state: fix panic in state dumping ethereum#22225
f90e268
@aaronbuchwald @gzliudan
core/state: remove toAddr helper in tests ethereum#22772
f943888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gzliudan @rjl493456442 @jsvisa @holiman @karalabe @aaronbuchwald