Require at least one auth #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (entry points configuration style) or not including a BaseAuthPlugin in loaded plugins, still allowed clients to connect to broker. security risk as explicit omission (former) or inadvertent omission (latter) might allow anonymous connections
HerrMuellerluedenscheid
approved these changes
Jul 3, 2025
ajmirsky
added a commit
to ajmirsky/amqtt
that referenced
this pull request
Jul 10, 2025
Require at least one auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
#187
Current behavior
If in a legacy (entrypoint) configuration, the auth plugin list is explicitly declared empty or in the config file-base plugin loading, no BaseAuthPlugin was included (or could provide a positive authentication), the broker would still allow clients to connect via anonymous authentication.
New behavior
In order for a broker to allow access, it must be configured with at least one
BaseAuthPluginwhich can positively authenticate a client session.Impact
While a security risk, the legacy behavior of omitting the auth plugin 'filter' in the configuration still allows anonymous clients to connect to the broker.
Checklist