syncronizedimages with their info, removed the progress bar, sped#17
Open
CodyRoy wants to merge 1 commit intoYaleSTC:masterfrom
Open
syncronizedimages with their info, removed the progress bar, sped#17CodyRoy wants to merge 1 commit intoYaleSTC:masterfrom
CodyRoy wants to merge 1 commit intoYaleSTC:masterfrom
Conversation
stswidwinski
reviewed
Apr 1, 2017
Contributor
stswidwinski
left a comment
stswidwinski
left a comment
There was a problem hiding this comment.
The idea is right in that the photo was too large. However, the solution has a bug :)
| sizes = response.getJSONObject("sizes").getJSONArray("size"); | ||
| photoUrl = sizes | ||
| .getJSONObject(sizes.length() - 1) | ||
| .getJSONObject(sizes.length() - 3) //finding a smaller size will speed up load times |
Contributor
There was a problem hiding this comment.
Bug:
what if the length of sizes is less than 3?
| Response.ErrorListener errorListener = new Response.ErrorListener() { | ||
| @Override | ||
| public void onErrorResponse(VolleyError error) { | ||
| //things2 |
| //things2 | ||
| } | ||
| }; | ||
| //solution is deprecated: better, worse or equivalent to hacky? |
Contributor
There was a problem hiding this comment.
What do you mean here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loads