Skip to content

Pull requests with unresolved comments were merged #10034

Description

@oxarbitrage

We often approve pull requests while also leaving review comments. This typically means the reviewer is approving the PR in general but expects the author to resolve the comments before merging.

In these situations, the pull request should not be merged until all comments are resolved.

However, #10019 was merged with an unresolved comment, and a follow-up PR had to be created (#10027).

It seems that this rule was lost during the latest CI refactor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-devopsArea: Pipelines, CI/CD and DockerfilesP-High 🔥

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions