fix(ci): rerun release dependency check on label#10955
Open
andres-pcg wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small GitHub Actions workflow to ensure the existing “check-no-git-dependencies” CI check runs when the A-release label is applied after a PR is already open (addressing the pull_request default-activity limitation in tests-unit.yml). This is a CI reliability improvement scoped to release-labeled PRs targeting main.
Changes:
- Add a dedicated workflow that triggers on
pull_requestlabeledevents and runs the “Check no git dependencies” job when the added label isA-release. - Reuse the same pinned actions and
cargo nextestinvocation as the existingtests-unit.ymljob.
This was referenced Jul 16, 2026
gustavovalverde
requested changes
Jul 16, 2026
gustavovalverde
left a comment
gustavovalverde
left a comment
Member
There was a problem hiding this comment.
Because check-no-git-dependencies already exists in another workflow, a whole workflow for a single check seems like too much. I think it should be possible to fix in tests-unit.yml
The check-no-git-dependencies job in tests-unit.yml is gated on the A-release label, but that workflow's pull_request trigger uses the default activity types (opened, synchronize, reopened). Adding the label to an existing PR therefore does not re-run it, so the check stays skipped until the next push. Add a dedicated workflow that triggers only on the labeled event and runs the same check, avoiding a full unit-test re-run on every label change.
gustavovalverde
force-pushed
the
ci/rerun-check-no-git-deps-on-label
branch
from
July 16, 2026 12:36
bc96217 to
f47bc2a
Compare
gustavovalverde
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding
A-releaseto an open pull request did not reruncheck-no-git-dependencies, so a Release PR could miss the dependency check until another commit was pushed.Solution
Handle label events in the existing Unit Tests workflow. Adding
A-releasereruns the same required-check path, while other labels skip every job and do not replace the aggregate unit-test result.Tests
actionlintandzizmorpass for the updated workflow.Closes #10897
AI Disclosure
Claude Code and OpenAI Codex were used to analyze the label trigger, edit the workflow, and draft the pull request description.