fix(ci): skip duplicate merge queue workflows#10973
Closed
gustavovalverde wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Zebra’s GitHub Actions workflows to avoid running expensive “source-only” CI jobs on temporary Mergify merge-queue candidate PRs, reducing redundant runner usage while preserving required merge-queue signals.
Changes:
- Skip the GCP deployment-image workflow’s root
set-matrixjob when the PR is a Mergify queue candidate (authormergify[bot], same-repo head,mergify/merge-queue/branch prefix), effectively skipping downstream expensive work for those candidates. - Skip the integration-test dispatch job for Mergify queue candidates while keeping existing behavior for source PRs,
mainpushes, and manual runs. - Skip the Docker validation workflow early for Mergify queue candidates, and prevent the final “alls-green” aggregator job from running when the workflow intentionally skipped at the entrypoint.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/zfnd-deploy-nodes-gcp.yml | Adds a Mergify-queue-candidate guard to set-matrix to skip downstream deployment-image-related jobs for queue candidates. |
| .github/workflows/trigger-integration-tests.yml | Adds a guard to avoid dispatching integration tests for Mergify queue candidates while retaining existing fork/manual/main-push rules. |
| .github/workflows/test-docker.yml | Adds an early guard to skip Docker validation on Mergify queue candidates and ensures the final aggregator job doesn’t run when the workflow is intentionally skipped. |
Member
Author
|
Superseded by #10971, which now owns the source-only policy and workflow skips for merge queue candidates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Mergify queue candidates repeat Docker configuration, deployment-image, and external integration workflows that already ran on the source PRs and are not required queue signals.
Solution
Skip those 3 workflows only for candidates that match the Mergify author, repository, and branch prefix. Required queue checks and fast docs and zizmor checks remain unchanged.
Tests
Workflow syntax, security checks, and the candidate predicate pass. Current Docker failures are fixed by #10967.
Refs #10963
AI Disclosure
OpenAI Codex was used for workflow implementation, testing, and this description.