This repository was archived by the owner on Jun 1, 2024. It is now read-only.
feat: beagle orange reviewed #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-by: Tiago Peres França <[email protected]> Signed-off-by: Hernand Azevedo <[email protected]>
hernandazevedozup
requested review from
arthurbleilzup,
dantes-git,
hectorcustodiozup,
jamessonpenhazup,
lucasfonsecazup,
tarcisiogc and
Tiagoperes
as code owners
Generated by 🚫 Danger |
hernandazevedozup
force-pushed
the
feature/orange-open-reviewed
branch
from
8c141f1 to
c7f2cac
Compare
Signed-off-by: Hernand Azevedo <[email protected]>
Signed-off-by: Hernand Azevedo <[email protected]>
uziassantosferreira
approved these changes
Jan 31, 2022
lucasfonsecazup
approved these changes
Jan 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request brings all the work from the team
Orange - UX Services - Beagle Open Coreto the Beagle Open Source project.Differently than most other projects, the Orange version of this was not a fork, which made this merge very hard. I tried to rebase it and to cherry pick the commits, nothing worked, there always was something missing at the end. To make sure everything from Beagle-Orange was coming, I chose the "nuclear" option, I copied the changes manually.
This is a single commit made by myself, but i'm only responsible for the merge. The actual authors of this code are: @uziasferreirazup, @hernandazevedo.
I checked it, everything but the following files are exactly the same as the version in the Orange repo:
If any important change was made to these files in the orange repo, they were lost. Can you confirm there was nothing important there @hernandazevedozup? I think we should keep these files as they are in the open source version.
Tasks for merging this into the main branch:
github/*is correct (@hernandazevedozup)Related PRs