Ensure we can drag to end of list #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, so... not surprisingly, this appears to be causing an issue at the other end. Need to think about this a bit more... |
|
OK, found something that works. While I am not certain this is the best solution, I figure putting this out there might be useful for anyone else who runs into the same issue. Also, it seems like I was having more of an issue with it when I am not using a strict vertical list, but when elements are lined up as floats. |
|
Addressing |
reesemartin
reviewed
Jul 13, 2018
source/sortable-item-handle.js
Outdated
| @@ -571,6 +584,7 @@ | |||
| * cancel the long touch and its timer. | |||
| */ | |||
| longTouchCancel = function() { | |||
| element.remmoveClass(sortableConfig.touching); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across what appeared to be a bug preventing me from being able to drag to the end of the list. Solution that appears to work is ensuring that when the target element is at the end, always insert the placeholder after. Seems to work and I have switched to using my fork in the meantime. This problem is best illustrated when attempting to drag the second item in the list to the last item.