CMake build system support#17
Conversation
abishekvashok
left a comment
abishekvashok
left a comment
There was a problem hiding this comment.
Please check the failing tests in Travis as well.
| #include <termios.h> | ||
| #include <signal.h> | ||
|
|
||
| #include "config.h" |
There was a problem hiding this comment.
config.h is generated using make and is needed for some configuration options that we will leave for the user.
|
i added a simple fix for config.h |
|
@hoijui can you modify the .travis.yml file as well so that we can make sure everything works well there as well. |
|
ok.. did that, and it seems to work :-) |
|
You can parallise the build. It's important to run tests on configure. https://docs.travis-ci.com/user/speeding-up-the-build/ If you can't find help. I would help on this. |
hoijui
force-pushed
the
cmake
branch
2 times, most recently
from
681484e to
8c8ae0b
Compare
|
thanks for the hint! |
| script: | ||
| - ./configure | ||
| - mkdir -p build | ||
| - cd build |
There was a problem hiding this comment.
Cd outside the build and then run configure
There was a problem hiding this comment.
so with configure, we can not make an out-of-source build?
why not.. and can we "fix" that?
There was a problem hiding this comment.
Basically the configuration file resides in the root directory of the project as a standard. Since you cd into build, it won't be there in the build folder and you are running ./configure which will make the shell to execute the configure file in ./ i.e, current folder(build).
|
ahh... |
|
Ah my bad, i will test this my local setup and let you know. |
|
Yes it works. Thanks for that! |
|
@hoijui could you provide a nice commit message so that I could squash and merge or just squash those commits |
|
... ok! i "beautified" the commit history now, leaving only two commits, which i though make sense separately. i checked that the content is still the same with (old history is now under https://github.com/hoijui/cmatrix/tree/cmake-develop) |
|
ouhh.. now thinking about it, should i also add something to README.md maybe? |
This allows for easy copy&paste of build instructions,
and also generates nice output with pandoc now.
You may test that with:
pandoc -f markdown -t HTML README.md > README.html
use like this:
mkdir -p build
cd build
cmake ..
# or
#cmake -DCMAKE_INSTALL_PREFIX=/usr ..
make
|
i did that, adding 4 READE modifying commits, of which the first 3 are independent of cmake, but for now i included them in this branch anyway. please say if i should separate them out into an other branch/pull request. they are minor though. |
|
Please separate them out. They should go on another issue with another pr. Please, revert those commits, they are causing build errors as well. |
|
actually, they are not producing the build errors, but the instability of the config build method is. i noted this a few times already, with this very same error ( |
|
it would be easiest if the README related pull request would be merge in first, and then these cmake changes afterwards. |
|
@hoijui done. |
|
thanks for the management work. :-) |
|
@hoijui would be happy if you could provide a nice descriptiuon as the commits will be squashed. |
|
you mean, you want a commit message for the merge commit, or you do not want to merge, but have a single, rebased, squashed commit? a description can be taken from this commit: |
|
I think you are right. |
|
:o wow. cool.. thanks! |
2 participants
adds basic support for building and installing CMatrix through CMake (a cross-platform meta-build system).
the binary should compiled on all platforms (untested), but the fonts are only installed on Unix systems.