Skip to content

Allow overriding only one template #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Nihisil opened this issue Feb 16, 2021 · 4 comments · Fixed by #183
Closed

Allow overriding only one template #166

Nihisil opened this issue Feb 16, 2021 · 4 comments · Fixed by #183
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right next major release This changes of code will added at next major release (*.0.0)

Comments

@Nihisil
Copy link

Nihisil commented Feb 16, 2021 •
edited
Loading

Right now if you specify --templates option it makes the tool load all templates from the provided folder.

And if there are missing files in this folder it raises an error.

I think it would be helpful to add fallback here and if in the provided folder template is not exists to load it from the default template folder.
@js2me js2me added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right next release labels Feb 16, 2021
@js2me
Copy link
Member

js2me commented Feb 16, 2021

Hello @Nihisil , thanks for this issue!
Yes, it is a good idea to customize only one template

@armsnyder armsnyder mentioned this issue Feb 22, 2021
Merged
@js2me js2me mentioned this issue Feb 24, 2021
Merged
@js2me
Copy link
Member

js2me commented Feb 24, 2021

5.1.7 Release has partial fix for this issue (Allow to remove all unused templates except templates used in ETA includeFile())

js2me added a commit that referenced this issue Feb 24, 2021
@js2me
BREAKING_CHANGE: fully rewrite render Eta templates process, overridi…
b4d2af4 
…ng only one template(#166), template path prefixes
@js2me
Copy link
Member

js2me commented Feb 25, 2021

It will fixed in 6.0.0 major version

@js2me js2me added next major release This changes of code will added at next major release (*.0.0) and removed next release labels Feb 25, 2021
@js2me js2me mentioned this issue Feb 28, 2021
Merged
@js2me js2me linked a pull request Feb 28, 2021 that will close this issue
Release 6.0.0 #183
Merged
@js2me js2me closed this as completed in #183 Mar 1, 2021
js2me added a commit that referenced this issue Mar 1, 2021
@js2me
Release 6.0.0 (#183)
4c3901f 
* BREAKING_CHANGE: fully rewrite render Eta templates process, overriding only one template(#166), template path prefixes

* docs: update README.md

* docs: update README

* docs: update README

* docs: add extra readmes for template folders

* docs: remove words about mustache version in README

* BREAKING_CHANGE: removed TPromise type

* feat: --axios option (axios based HttpClient class)

* bump: up version to 6.0.0

* fix: support of older templates; fix: spec_templates test; chore: apply comments for axios http client
@js2me
Copy link
Member

js2me commented Mar 1, 2021

@Nihisil it should be fixed in 6.0.0
Thank you for issue !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right next major release This changes of code will added at next major release (*.0.0)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 6.0.0 acacode/swagger-typescript-api
2 participants
@Nihisil @js2me