Content-Type: "multipart/form-data" is ignored

[inomn]

In generated axios http-API client there's a line

headers: {
        ...(requestParams.headers || {}),
        ...(type && type !== ContentType.FormData ? { "Content-Type": type } : {}),
      },

this prevents us from sending a request with content-type multipart/form-data.
Could anyone tell me what the reason was for this solution?

Replacing this with a simple

      headers: {
        ...(requestParams.headers || {}),
        "Content-Type": type
      },

fixes the issue

[Isola92]

I think the header is applied automatically by the browser when passing a FormData object in the body. Not sure if that holds true for Axios though but this appears to be the behavior for me using fetch.

[inomn]

@Isola92 Not the case for Axios + latest Chrome

[ThomasGuenard]

Same behavior using react-native:

We have to pass content-type with the header param to be able to send form-data.
As the generated request have already the type, it is sad to redefined it manually

[cf-dlangston]

It seems like the change adding this ...(type && type !== ContentType.FormData ? { "Content-Type": type } : {}), was part of PR #173. The rationalization in the PR being:

It's better to let the browser handle setting of this content-type, since it will add the correct boundary.

This corroborates what @Isola92 is saying. To fix I think it makes sense to remove this check from the axios-http-client.ejs template since axios doesn't automatically add this header. I just submitted MR #831 which does this.