Skip to content

Remove redundant union-enums option in favor of generate-union-enums #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

dding-g
Copy link
Contributor

@dding-g dding-g commented Mar 26, 2025

Options name needs to change.

edca5de
as this commit, --union-enum option needs to change --generate-union-enums. :)

Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 6a74f6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
swagger-typescript-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dding-g dding-g marked this pull request as draft March 26, 2025 10:09
@dding-g dding-g marked this pull request as ready for review March 26, 2025 10:10
@smorimoto smorimoto added bug Something isn't working documentation Improvements or additions to documentation labels Mar 26, 2025
@smorimoto smorimoto requested review from smorimoto and Copilot March 26, 2025 10:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the command-line option from "--union-enums" to "--generate-union-enums" to reflect updated naming conventions.

  • Update test name to use "--generate-union-enums"
  • Update README documentation to reflect the new option
  • Remove the outdated option configuration from the command definition in index.ts

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
tests/spec/unionEnums/basic.test.ts Updated test case name to match the new option
README.md Updated option documentation to reflect the new option name
index.ts Removed the old "--union-enums" option configuration block
Files not reviewed (1)
  • tests/spec/unionEnums/snapshots/basic.test.ts.snap: Language not supported
Comments suppressed due to low confidence (1)

index.ts:281

  • The removal of the 'union-enums' option configuration without a corresponding replacement for '--generate-union-enums' may lead to the new option being undefined. Please add a configuration block for '--generate-union-enums' to ensure proper functionality.
    -    "union-enums": {

Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
@smorimoto smorimoto changed the title --union-enums option names fix to --generate-union-enums Remove redundant union-enums option in favor of generate-union-enums Mar 26, 2025
@smorimoto smorimoto merged commit 821bfad into acacode:main Mar 26, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Mar 26, 2025
@smorimoto smorimoto linked an issue Mar 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] --union-enums cli flag no longer works in 13.0.28
2 participants