Skip to content

Fix boolean enum handling #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2021
Merged

Fix boolean enum handling #210

merged 3 commits into from
Mar 19, 2021

Conversation

haedaal
Copy link
Contributor

@haedaal haedaal commented Mar 19, 2021

Hello.
First, I really appreciate typescript-specialized codegen project!
I've got here searching for alternatives to swagger-codegen, openapi-generator as both of these didn't feel seamless & neat with typescript.

Trying swagger-typescript-api, I found this little bug. please give me a feedback :)

as-is:

export type BooleanEnum = "true" | "false";

to-be:

export type BooleanEnum = true | false;

@js2me js2me changed the base branch from master to next March 19, 2021 06:40
@js2me
Copy link
Member

js2me commented Mar 19, 2021

Hello @haedaal !
Thanks for this kind words!
And for this good PR!

@js2me js2me merged commit f63a008 into acacode:next Mar 19, 2021
js2me added a commit that referenced this pull request Mar 19, 2021
* feat: add "onFormatRouteName" hook

* chore: try to add github workflows

* chore: rename gh workflow file to main

* chore: fix changelog after rebase

* fix incorrect working --route-types with --modular option   (#207)

* chore: try to fix modular route types problem

* fix: --route-types with --modular option; fix: better format namespace name (--route-types)

* feat: add extra output util functions

* chore: improve getTemplate function

* fix: getting template content by getTemplate by path

* fix: getTemplate by path

* chore: fix typings for rawModelTypes

* feat: add formatTSContent util function

* Fix boolean enum handling (#210)

* Add boolean enum example

* Fix boolean enum handling

* chore: up lodash to latest

* bump: up version to 7.0.0; feat: add returning `false` in `onCreateRoute` hook

Co-authored-by: Minjae Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants