Consider 2xx a successful status #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wyozi for PR! |
js2me
added a commit
that referenced
this pull request
Apr 29, 2021
* Consider 2xx a successful status (#238) * fix: add array params with key (#237) * fix: add array query params with key * chore: use encoded key and value for array params Co-authored-by: Sascha Galley <[email protected]> * disableProxy option, added catch to axios get (#232) * fix(types): add silent as param in declarations (#241) * axios file upload formData Type (#244) * axios file upload formData Type * fix error FormData is not undefined. when serverside request Co-authored-by: guhyeon <[email protected]> * docs: update CHANGELOG * chore: make property instance public * chore: refresh generated schemas * fix: variable name "params" doesn't uniq (thanks @mixalbl4-127) * chore: replace log to errorLog * refactor: resolving specific arg names * docs: update CHANGELOG * feat: --extract-request-body cli option (extractRequestBody: false); refactor: logger; BREAKING_CHANGE: remove deprecated code in apiConfig * fix: utils type in .d.ts * Add TSDoc tag for deprecated routes (#246) * chore: refresh generated schemas; fix: form data body for axios request method * bump: up version to 9.0.0 Co-authored-by: Joonas <[email protected]> Co-authored-by: Sascha Galley <[email protected]> Co-authored-by: Sascha Galley <[email protected]> Co-authored-by: Fabio <[email protected]> Co-authored-by: Matt R. Wilson <[email protected]> Co-authored-by: guhyeon <[email protected]> Co-authored-by: guhyeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI allows specifying range response codes (https://swagger.io/docs/specification/describing-responses/). I don't think it's particularly good code style tbh, but "2xx" should still probably be considered a successful response