fix(deprecated): property with deprecated=false was shown as @deprecated #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same question here @js2me, can you elaborate on why this PR has been closed? Thx! |
|
@qboot This PR was closed automatically after delete next branch |
|
Please apply this changes to |
qboot
commented
Oct 24, 2022
| @@ -5,7 +5,7 @@ const { formatDescription, require, _ } = utils; | |||
| const jsDocLines = _.compact([ | |||
| data.title, | |||
| data.description && formatDescription(data.description), | |||
| data.deprecated === true && '@deprecated', | |||
| !_.isUndefined(data.deprecated) && data.deprecated && '@deprecated', | |||
|
@qboot thank you for you contribution ! |
js2me
added a commit
that referenced
this pull request
Oct 27, 2022
* docs: add link to article about swagger typescript api lessons in README * fix: problems with path params with dots * internal: add gitattributes * feat: ability to modify code gen constructs; feat: --another-array-type cli option (Array<Type>); docs: update CHANGELOG, README * bump: 11.0.0; refactor: codebase of project, `data-contract-jsdoc.ejs` incompatible with prev version, see CHANGELOG * docs: typo fix * feat: improve jsdoc fields declaration * docs: update README * chore: add .nvmrc * fix: problems due to new version; feat: new cli utility * fix(deprecated): property with deprecated=false was shown as deprecated (#421) * document approach to disabling output (#325) * Added "generateClient", "typePrefix", "typeSuffix" options to readme for NodeJS usage (#335) Co-authored-by: Feargal Kavanagh <[email protected]> Co-authored-by: Sergey S. Volkov <[email protected]> * fix: ci\cd build; fix: try\catch for cli operation * refactor: templates * fix: replace Iterable<any> to any[] in axios-http-client to solve type bugs linked with Iterable * feat: add new command (generate-templates) * docs: update CHANGELOG * fix: tests, scriptsRunner Co-authored-by: Quentin Brunet <[email protected]> Co-authored-by: Ben Watkins <[email protected]> Co-authored-by: Feargal Kavanagh <[email protected]> Co-authored-by: Feargal Kavanagh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes have in our OpenAPI schema some properties with the
"deprecated": falseflag.These properties are annotated as
@deprecatedeven with the flag set tofalse.This PR fixes this issue and add a related test.