chore: remove useless trailing whitespaces which make test edit harder #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qboot LGTM, please run test all script and push commit with changes |
|
I've already run |
|
@qboot thank you for your contribution ! |
|
@all-contributors please add @qboot for code |
|
I've put up a pull request to add @qboot! 🎉 |
Merged
js2me
added a commit
that referenced
this pull request
Oct 21, 2022
* fix: problem with default http request headers in axios client * feat: improve type declaration for inline types; fix: nullable option for objects * fix: problem with sortTypes option; docs: update CHANGELOG * docs: update README linked with custom templates * feat: separate data-contracts.ejs onto 4 pieces (enum, interface, type, jsdoc) * fix createFormData code duplication (#392) * chore: add title for DC in jsdoc; internal: add templates for future improvements * fix: problem with host.fileExists is not a function chore: set all deps as fixed versions * fix: order of headers in fetch http client * fix: max file size for axios (fetching swagger file) * fix: fs.rmSync usage * fix: getNewLine, readFile in LanguageServicehost (ts) * docs: add docs for unwrapResponseData flag * fix: problems with nested required properties based with upper required properties * chore: refresh test generated schemas * bump: up version to 10.0.3, update CHANGELOG * docs: update changelog * test: add module assertions in spec tests * chore: remove useless trailing whitespaces which make test edit harder (#422) * fix: replace CRLF -> LF (unix support) * fix: replace CRLF -> LF (unix support) (test schemas) * docs: add missing addReadonly property * chore: add logging (project version, node version, npm version) * bump: up version to 10.0.3; docs: update CHANGELOG Co-authored-by: Oleg Kuzava <[email protected]> Co-authored-by: Quentin Brunet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are using VSCode and are trying to contribute to this project, there is a chance that you have the setting
"files.trimTrailingWhitespace": true,enabled, like me.And it took me some time to understand why my test suite was failiing.
I think this small fix can be useful even if you don't enforce any particular convention regarding trailing spaces.
What do you think?