Skip to content

fix: onCreateRoute skip behaviour #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix: onCreateRoute skip behaviour #476

merged 1 commit into from
Mar 22, 2023

Conversation

ivanovart
Copy link

@ivanovart ivanovart commented Dec 25, 2022 •
edited
Loading

I appears that the behaviour described in docs to skip the endpoint when onCreateRoute hook returns false was removed in v11
change -> src/routes.js

@ivanovart
Copy link
Author

@js2me, can you take a look please?

@hanc2006
Copy link

hanc2006 commented Feb 7, 2023

I have the same issue. I cannot skip one route returning false

@js2me js2me changed the base branch from next to master March 22, 2023 22:50
@js2me js2me changed the base branch from master to next March 22, 2023 22:50
@js2me js2me merged commit b38cd83 into acacode:next Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanovart @hanc2006 @js2me